improve formatDate function with keepLocalTime argument #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you implement SDESK-7350 the issue that you're trying to solve in this PR would be solved as well. |
|
@tomaskikutis Thats what I thought... this should be a quick fix for now (we need to have it tomorrow) while we work on improving those functions in the meantime... |
|
the one in the ticket is a quick fix as well, going over existing usages will take longer, but as I said we can do it in another PR |
tomaskikutis
approved these changes
Jul 24, 2024
dzonidoo
added a commit
to dzonidoo/superdesk-client-core
that referenced
this pull request
Jul 24, 2024
dzonidoo
added a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TGA-104
linked issue- SDESK-7350